gorilla-devs / ferium

Fast and multi-source CLI program for managing Minecraft mods and modpacks from Modrinth, CurseForge, and GitHub Releases
Mozilla Public License 2.0
1.15k stars 49 forks source link

GUI file dialogue not working on WSL #351

Open Aleosiss opened 1 year ago

Aleosiss commented 1 year ago

Description

When attempting to set a mod output directory, the dialogue instantly closes and I am unable to enter a path.

https://github.com/gorilla-devs/ferium/assets/25385833/4a78fcd9-4e9c-40c3-9311-7e277a3db871

Steps to reproduce

From the history output on a fresh install of Ubuntu on WSL2.0

  1. curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
  2. source "$HOME/.cargo/env"
  3. sudo apt-get update
  4. sudo apt install build-essential
  5. cargo install ferium
  6. ferium modpack add kosmolot-unofficial-masa-mods

Operating System

Linux

Are you using the latest version of ferium?

Additional Information

Installing on WSL2

theRookieCoder commented 1 year ago

I would recommend using the no-gui version (cargo install ferium --no-default-features) for now while I figure this out.

ok-coder1 commented 2 weeks ago

@theRookieCoder, you could add a option in ferium for typing the path in.

theRookieCoder commented 2 weeks ago

@theRookieCoder, you could add a option in ferium for typing the path in.

There is, all commands that have any directory argument have command line flags for it.

ok-coder1 commented 2 weeks ago

@theRookieCoder, you could add a option in ferium for typing the path in.

There is, all commands that have any directory argument have command line flags for it.

So, shouldn't this be closed?

theRookieCoder commented 2 weeks ago

No, the GUI file dialogue still doesn't work via WSL to my knowledge? The command line flag and nogui are just workarounds.

ok-coder1 commented 2 weeks ago

How does the dialog box work? It's supposed to be using the Windows dialogue box as AFAIK, WSL doesn't have(install) the Linux file selection dialog right?

theRookieCoder commented 2 weeks ago

I use this library called rfd, on linux (including anything running inside WSL) it will communicate using the xdg desktop portal to use the system's default file picker.