search

gorilla-devs / ferium

Fast and multi-source CLI program for managing Minecraft mods and modpacks from Modrinth, CurseForge, and GitHub Releases
Mozilla Public License 2.0
1.14k stars 47 forks source link

Scan the output directory and add mods found to the profile #57

Closed theRookieCoder closed 3 months ago

theRookieCoder commented 2 years ago

Modrinth has the functionality to find out which Version a local file belongs to (https://docs.modrinth.com/api-spec/#operation/versionFromHash)
CurseForge seems to have this functionality through 'fingerprints' but I haven't figured it out yet Functionality for this in GitHub Releases is not possible

JustSimplyKyle commented 2 years ago

So if this is added, which also means hash checking getting added too? https://github.com/theRookieCoder/ferium/issues/34#issuecomment-1114710687 https://github.com/theRookieCoder/ferium/issues/49#issuecomment-1120360382 I think these two can also be added via the same logic Well for github releases, maybe say something on README that it doesn't have as much functionality so use modrinth, curseforge, and then github releases

JustSimplyKyle commented 2 years ago

ALso which platform should we use first? I guess modrinth would be great. But there is a slight problem with that. Because modrinth isn't the first platform of choice for mod developers, some mod developers will have slower update cycles on modrinth. I've encountered such problem before but I forgot which mods had them found it. https://modrinth.com/mod/lightest-lamps/versions https://www.curseforge.com/minecraft/mc-mods/lightest-lamps-fabric

theRookieCoder commented 2 years ago

which also means hash checking getting added too?

Yes, the age old problem will be fixed

theRookieCoder commented 2 years ago

As suggested in #64, we should also support adding mods from a file

Cloudate9 commented 2 years ago

Hey there, @theRookieCoder

I'm one of the main developers of ReviversMC/the-mod-index, and, although it seems you have a plan for adding this functionality, I'd like to propose our repo for helping you out.

While it is not yet complete, we're pretty dang close, and I think It'd help you a lot!
We currently do not have a Rust api though, but simple http calls to GitHub will do the job (api contributions always welcome)

If you'd like to get in touch with us for more details, you can find us on Discord :slightly_smiling_face:

kappa-maintainer commented 2 years ago

I found another project that has implemented this feature for some time: https://github.com/packwiz/packwiz

Bluscream commented 2 years ago

I consent with this request!

theRookieCoder commented 1 year ago

If you're wondering why it's taking so long, it's because I have to implement some improvements to the add command such as multiple add, nested dependencies, and a more comprehensive mod resolution checking and override flags system.

Bluscream commented 11 months ago

Chill. Its been only a year. Give them atleast till minecraft 1.40

PockySweet commented 4 months ago

One day it will happen!

theRookieCoder commented 4 months ago

It will hopefully be soon since the primary blocking issue for this (#175) has been resolved!

theRookieCoder commented 4 months ago

I have implemented the feature, I'll test and release it hopefully by tomorrow.

https://fosstodon.org/@theRookieCoder/112597787974114828

theRookieCoder commented 4 months ago

You can try it out now by compiling from the repo or using the actions artefacts.