search

gorilla / css

Package gorilla/css is a CSS3 tokenizer.
https://gorilla.github.io
BSD 3-Clause "New" or "Revised" License
86 stars 36 forks source link

Doesn't support escaped code points? #14

Open alin04 opened 5 years ago

alin04 commented 5 years ago

The "consume an escaped code point" rule doesn't appear to be implemented?

kisielk commented 5 years ago

I don’t believe it does. If you’re interested in adding support a PR with tests would be welcome.

On Dec 6, 2018, at 16:28, Angie Lin notifications@github.com wrote:

The "consume an escaped code point" rule doesn't appear to be implemented?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

alin04 commented 5 years ago

I see #13 is almost a total rewrite that does support escapes. What's the status of the PR?

kisielk commented 5 years ago

Honestly I haven't had the time to review it in full or come up with a strategy on migrating the package to a new version.

alin04 commented 5 years ago

Ok. I might add a fix to the current impl then...