Closed sy9 closed 1 year ago
Merging #733 (f7e3116) into main (4a671cb) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #733 +/- ##
=======================================
Coverage 78.04% 78.04%
=======================================
Files 5 5
Lines 902 902
=======================================
Hits 704 704
Misses 142 142
Partials 56 56
Thanks for the contribution @sy9 ! Looks good to me.
What type of PR is this? (check all applicable)
Description
Changed the SPA handler example in README.md in two areas. First, made sure to actually include the requested path in the call to
filepath.Join
. Secondly, if the requested path hits a directory, I think it would be beneficial to also serve theindexPath
file, and not list the directory contents. I also edited the comments in theREADME.md
file accordingly.Related Tickets & Documents
Added/updated tests?
README.md
, if any tests are necessary please let me knowRun verifications and test
make verify
is passingmake test
is passing