gorilla / mux

Package gorilla/mux is a powerful HTTP router and URL matcher for building Go web servers with 🦍
https://gorilla.github.io
BSD 3-Clause "New" or "Revised" License
20.92k stars 1.85k forks source link

fix(#739): Remove else statement on route mismatch #746

Closed marcelom97 closed 10 months ago

marcelom97 commented 11 months ago

What type of PR is this? (check all applicable)

Description

When a path with specific query params does not match we should return a ErrMethodMismatch instead of ErrNotFound

Related Tickets & Documents

Added/updated tests?

Run verifications and test

jaitaiwan commented 10 months ago

I've reviewed and I'm happy with the code and tests to match. What needs to be considered now is if this is technically a breaking api change or not as folks utilising the library may expect the former error. @AlexVulaj would love your input on this.

jaitaiwan commented 10 months ago

Actually I got confused - this PR (thanks to #748) is now obsolete. Thank you heaps for the contribution @marcelom97. If you feel that this was in error, please open up another issue to discuss.