Closed marcelom97 closed 10 months ago
I've reviewed and I'm happy with the code and tests to match. What needs to be considered now is if this is technically a breaking api change or not as folks utilising the library may expect the former error. @AlexVulaj would love your input on this.
Actually I got confused - this PR (thanks to #748) is now obsolete. Thank you heaps for the contribution @marcelom97. If you feel that this was in error, please open up another issue to discuss.
What type of PR is this? (check all applicable)
Description
When a path with specific query params does not match we should return a ErrMethodMismatch instead of ErrNotFound
Related Tickets & Documents
Added/updated tests?
Run verifications and test
make verify
is passingmake test
is passing