gorilla / schema

Package gorilla/schema fills a struct with form values.

https://gorilla.github.io

BSD 3-Clause "New" or "Revised" License

1.39k stars 231 forks source link

use full match instead of strings.HasPrefix #178

Closed tuhao1020 closed 2 years ago

tuhao1020 commented 3 years ago

176

https://github.com/gofiber/fiber/issues/1414

chunhui-pang commented 3 years ago

This patch fixed the problem definitely. However, it introduced another problem that recursive structs cannot be serialized. I think it may be better to check if there is a dot after the prefix

tuhao1020 commented 3 years ago

@chunhui-pang Could you please provide more details about recursive structs serialization?

ReneWerner87 commented 3 years ago

@chunhui-pang could you check the code

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days.

gaby commented 2 months ago

@stale this is not stale

gaby commented 2 months ago

@elithrar @lll-lll-lll-lll @kisielk Any chance of getting this merged, it is still a problem.

jaitaiwan commented 2 months ago

The recursive structure issues would be good to see, I’ll reopen and see if there’s a response.

@AlexVulaj how come I can’t reopen this? lol

gaby commented 2 months ago

@jaitaiwan Maybe stale overrides that? I can open a new PR if needed

lll-lll-lll-lll commented 2 months ago

ok, I'm going to start contributing again from now on. thanks for mention.