Closed coreydaley closed 1 year ago
@coreydaley I saw you're planning to get rid of CircleCI settings. But, I've got a different idea that could be great for this project.
I've sent a Pull Request (https://github.com/gorilla/sessions/pull/262 https://github.com/gorilla/securecookie/pull/79) where I've switched CircleCI over to GitHub Actions. With this, we can still do all our old tests and even use the newest version of Go. It's like keeping the good stuff we had and making sure it works with any new Go versions too.
If we just delete CircleCI and don't replace it with something like GitHub Actions, we might mess up our tests or have issues with the newest Go. But with GitHub Actions, we keep our testing strong and up-to-date, which is really good for our work here.
I think my PR is a good move for the project. I hope you can take another look at it. Let me know if you've got any questions, okay?
@catatsuy Thank you for the pull request, we are currently working on swapping out circleci for github actions as part of the project transition, starting with https://github.com/gorilla/mux/pull/718
:exclamation: No coverage uploaded for pull request base (
main@956d3cf
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage ? 76.86%
=======================================
Files ? 4
Lines ? 268
Branches ? 0
=======================================
Hits ? 206
Misses ? 54
Partials ? 8
Fixes #
Summary of Changes
1.