search

gornostal / Modific

Highlight lines changed since the last commit (supports Git, SVN, Bazaar, Mercurial and TFS) / ST2(3) plugin
614 stars 44 forks source link

ST3 Support #38

Closed svizzari closed 11 years ago

svizzari commented 11 years ago

Modific fails under ST3 beta (3010) with the following:

reloading plugin Modific.Modific
Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 70, in reload_plugin
    m = importlib.import_module(modulename)
  File "X/importlib/__init__.py", line 88, in import_module
  File "<frozen importlib._bootstrap>", line 1577, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1558, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1525, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 586, in _check_name_wrapper
  File "<frozen importlib._bootstrap>", line 1023, in load_module
  File "<frozen importlib._bootstrap>", line 1004, in load_module
  File "<frozen importlib._bootstrap>", line 562, in module_for_loader_wrapper
  File "<frozen importlib._bootstrap>", line 854, in _load_module
  File "<frozen importlib._bootstrap>", line 981, in get_code
  File "<frozen importlib._bootstrap>", line 313, in _call_with_frames_removed
  File "/Users/<user>/Library/Application Support/Sublime Text 3/Packages/Modific/Modific.py", line 113
    except subprocess.CalledProcessError, e:
gornostal commented 11 years ago

I would like to add support of ST3 but unfortunately I don't have a license. So I can do this only after ST3 will be available without license.

svizzari commented 11 years ago

No problem, thanks for the update. Modific is a great plugin, by the way!

beefsack commented 11 years ago

Hi @gornostal,

How would you feel about me sponsoring development by purchasing you a license? Please contact me at mick@miniand.com if you are interested, modific is a great plugin and I'd love to be using it under ST3.

gornostal commented 11 years ago

@beefsack sounds great! Emailed.

gornostal commented 11 years ago

Done.

@beefsack thank you very much for the license.

beefsack commented 11 years ago

It's now working perfectly here, cheers! :smile: