search

gornostal / Modific

Highlight lines changed since the last commit (supports Git, SVN, Bazaar, Mercurial and TFS) / ST2(3) plugin
614 stars 44 forks source link

Updated Icon path to work with changes from ST3 build 3014 #40

Closed jlangston closed 11 years ago

jlangston commented 11 years ago

ST3 build 3014 had some changes to how gutter icons worked which in turn breaks Modific's gutter icons from being shown properly. I've updated the path to the icons to make Modific work with build 3014.

for more info on this build see http://www.sublimetext.com/forum/viewtopic.php?f=2&t=11352

gornostal commented 11 years ago

This patch breaks backward compatibility. I already added a workaround for this issue with icons. Plugin creates directory Theme - Default where Sublime is looking for icons: https://github.com/gornostal/Modific/commit/423242d2f52d223088ae6f4e5e8a1dbe6f266ca8 Does it work for you?

jlangston commented 11 years ago

It was working in ST3 before build 3014 but not after. This build broke gutter icons for BracketHighlighter as well. Changes were made to that plugin to fix gutter icons for this build as well

See https://github.com/facelessuser/BracketHighlighter/commit/28eb130614edfd715cd84c662dfc95c4d965e7

From those changes it doesn't need to create the Theme - Default directory but also won't work on earlier versions as you mentioned.

gornostal commented 11 years ago

Okay. So I'm going to make a fix that will remain BC. But I won't push it to the master until next stable build will be released.

gornostal commented 11 years ago

updated python3 branch

gornostal commented 11 years ago

Thank you for pointing out on this solution.

jlangston commented 11 years ago

Sounds good. Thanks for the great plugin.