search

gornostal / Modific

Highlight lines changed since the last commit (supports Git, SVN, Bazaar, Mercurial and TFS) / ST2(3) plugin
614 stars 44 forks source link

please add execution delay #44

Closed ghost closed 11 years ago

ghost commented 11 years ago

I have a couple of ST2 plugins which execute on "save action". As a result, Modific fails to execute randomly. When I disable other "save action" plugins, Modific works fine. I've solved this problem by adding 50ms execution delay for Modific in my local files.

I request officially adding a small delay in Modific code for delaying executing svn commands by a small mount, say 10 or 50 ms.

gornostal commented 11 years ago

Hi, I won't do that. I didn't encounter this issue, although I also have few plugins (including Modific) that have on-save action and everything works fine for me. It seems like a ST issue, not Modific's.

ghost commented 11 years ago

Well, having a 10-20ms delay might be a good practice in general. Besides it's only 2-3 lines of code change. Maybe I can send a patch?

gornostal commented 11 years ago

I just don't want to have this hack in the plugin. Can you tell how to reproduce this issue? Maybe I can see another way around.

ghost commented 11 years ago

I've seen that there's an update to Modific, let me try to use it for a few days to see how it goes. I'll get back if I can collect proper logs. Thanks.