search

gornostal / Modific

Highlight lines changed since the last commit (supports Git, SVN, Bazaar, Mercurial and TFS) / ST2(3) plugin
614 stars 44 forks source link

fix diffing on mac systems #60

Closed cartazio closed 10 years ago

cartazio commented 10 years ago

seems to fix the problem on my machine. notice how i make a change that should only impact behavior on macs and leave everything else as before

JulianNorton commented 10 years ago

Does this fix the hotkeys not working on mac?

marclundgren commented 10 years ago

cmd + alt + d toggles the Dockbar ctrl + alt + d brings up a dictionary dialog

marclundgren commented 10 years ago

dication

cartazio commented 10 years ago

My patch doesn't address any key binding mapping. Merely fixes how certain files with Unicode would make modific fail on OS x 10.9 with ST3

On Thursday, January 16, 2014, Marc Lundgren notifications@github.com wrote:

[image: dication]https://f.cloud.github.com/assets/1154834/1933413/3448a9ea-7edb-11e3-9d4c-59e8705213e0.png

— Reply to this email directly or view it on GitHubhttps://github.com/gornostal/Modific/pull/60#issuecomment-32502041 .

JulianNorton commented 10 years ago

I've opened a new issue https://github.com/gornostal/Modific/issues/61

gornostal commented 10 years ago

@cartazio thanks for the pull request. Although you fix had one issue. I already fixed it and pushed to my cartazio-master branch.

I need a couple of days to test this fix and then I'll merge it.

It would be great, if you could share a file that was causing an exception, so I would have something to test on.

cartazio commented 10 years ago

heres a link to the file https://raw.github.com/wellposed/hOpenBLAS/master/readme.md

cartazio commented 10 years ago

notice the ® character. oddly when i deleted the ® character it still would throw errors