search

gornostal / Modific

Highlight lines changed since the last commit (supports Git, SVN, Bazaar, Mercurial and TFS) / ST2(3) plugin
614 stars 44 forks source link

Problems with non-utf8 files and national characters #76

Closed paulikt closed 9 years ago

paulikt commented 10 years ago

First of all: Modific is a great help while I'm working.

But when the file is not in utf-8 (I'm often working with iso-8859-2 - Central European files) and the file contains some "special" national characters like in "árvíztűrő tükörfúrógép" I get errors like this:

Exception in thread Thread-108:
Traceback (most recent call last):
  File "X/threading.py", line 639, in _bootstrap_inner
  File "Modific in /home/paulik/.config/sublime-text-3/Installed Packages/Modific.sublime-package", line 158, in run
  File "X/subprocess.py", line 906, in communicate
  File "X/subprocess.py", line 1531, in _communicate
  File "X/subprocess.py", line 831, in _translate_newlines
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 396: invalid continuation byte

iso-8859-2 files without any unusual characters are working fine.

I would appreciate any help.

gornostal commented 10 years ago

Thanks:)

@paulikt what OS are you using? Is it Sublime Text 2 or 3?

paulikt commented 10 years ago

Hi!

I'm using Sublime3 in a Ubuntu 12.04 x32 environment.

gornostal commented 9 years ago

@paulikt please try to reproduce with the latest Modific. Issue should be fixed now.

And thanks for the patience.

paulikt commented 9 years ago

Hi!

I can confirm, that the issue is gone. Thanks!

gornostal commented 9 years ago

Great! Thanks.