search

gornostay25 / svelte-adapter-bun

A SvelteKit adapter for Bun
MIT License
534 stars 33 forks source link

Host header fallback #40

Closed kolchurinvv closed 9 months ago

kolchurinvv commented 1 year ago

after a recent update host_header is not defined / empty string ... for some reason

kolchurinvv commented 1 year ago

solves #39

kolchurinvv commented 12 months ago

@silvio2402 thank you for the advice. makes sense. applied the change

chevcast commented 12 months ago

I've forked this repo and published my own NPM package. The fix for this issue is already merged into my fork and I plan to keep it updated. Anyone else having this issue is free to use it if you'd like:

bun add @catdadcode/svelte-adapter-bun -D

https://github.com/catdadcode/svelte-adapter-bun

I've also added signal event handling to the fork. Previously if you ran your Svelte app in a Docker container then killing the container would take 10+ seconds before Docker would force kill it. The resulting build/ app from this adapter now has proper process signal handling and will gracefully shutdown immediately upon receiving any of SIGTERM, SIGINT, SIGQUIT, SIGSTOP, or SIGKILL.

silvio2402 commented 12 months ago

I've forked this repo and published my own NPM package. The fix for this issue is already merged into my fork and I plan to keep it updated. Anyone else having this issue is free to use it if you'd like:

Thanks for your efforts. It'd also be great if you could make a PR in this repository so all users can benefit from your changes.

chevcast commented 12 months ago

I've forked this repo and published my own NPM package. The fix for this issue is already merged into my fork and I plan to keep it updated. Anyone else having this issue is free to use it if you'd like:

Thanks for your efforts. It'd also be great if you could make a PR in this repository so all users can benefit from your changes.

I'll be happy to do so if this repo starts rolling in changes again. As it stands Bun is linking over to my fork for now (I didn't ask for that. Jarred just noticed somehow.). I'll be rewriting this adapter a bit as well, including adding tests.

dimdenGD commented 9 months ago

@gornostay25 Why you're not merging this? Currently every single person who installs your adapter gets this error and has to look into open issues and then find this PR and get the fork instead.

kolchurinvv commented 9 months ago

I'd just switch to the adapter maintained by @catdadcode 😃

dimdenGD commented 9 months ago

It'd probably be nice to include that in the Readme

gornostay25 commented 9 months ago

Fixed: https://github.com/gornostay25/svelte-adapter-bun/pull/47