search

gornostay25 / svelte-adapter-bun

A SvelteKit adapter for Bun
MIT License
537 stars 34 forks source link

Add handler.js to entrypoints #41

Closed silvio2402 closed 9 months ago

silvio2402 commented 1 year ago

This change exposes the handler function (wrapper) to allow running custom servers. Exposing a handler function directly like in the adapter-node package would be a potential improvement. Resolves #28 and #37.

chevcast commented 1 year ago

I've gone ahead and merged this change into my fork at v0.5.6 in case you want to use it.

bun add -D @catdadcode/svelte-adapter-bun@0.5.6

https://github.com/catdadcode/svelte-adapter-bun

I plan to maintain this fork and contitnue to roll in updates from this repo.

silvio2402 commented 1 year ago

I've gone ahead and merged this change into my fork at v0.5.6 in case you want to use it.

@catdadcode thanks for your efforts. However it looks like the latest version of your NPM package @catdadcode/svelte-adapter-bun@0.5.6 doesn't include this commit: catdadcode/svelte-adapter-bun@9428ee9.

chevcast commented 1 year ago

I've gone ahead and merged this change into my fork at v0.5.6 in case you want to use it.

@catdadcode thanks for your efforts. However it looks like the latest version of your NPM package @catdadcode/svelte-adapter-bun@0.5.6 doesn't include this commit: catdadcode/svelte-adapter-bun@9428ee9.

This should be remedied in 0.5.7. I believe I had forgotten to build before publish. Please let me know if you still have issues. Also make sure you're both updating the version in package.json and running bun install to install the updated version. I also added a "prepublish" script to ensure builds run whenever it's about to publish to the registry to help prevent me forgetting to do so after making changes.