search

gorork / paper-audio-player

A custom audio player with paper material style
http://nadikun.com/code/paper-audio-player/demo
MIT License
197 stars 58 forks source link

Media session support #36

Open kalaspuffar opened 7 years ago

kalaspuffar commented 7 years ago

Listened to a video about the media session API (https://www.youtube.com/watch?v=57Scec2XPd0) and I thought it would be nice to have it in the paper-audio-player.

So I did a rudimentary implementation of this API. What do you think @gorork ?

gorork commented 7 years ago

@kalaspuffar Awesome feature! 👍 Do you have an Android device to test this feature live?

kalaspuffar commented 7 years ago

Hi @gorork

Well I have a Nexus 6P. I didn't have a cord at work last but today I brought one and tested. It works in Chrome Beta for Android. Beta builds are at version 58, the function came in 57.

So in the current chrome version of 56 it will not work but I guess that 57 is just around the corner. But when I've changed the callbacks to be anonymous functions it worked fine.

If you have it a description, album art and so on can be displayed so if you like I can add those as properties.

Test page from google: https://googlechrome.github.io/samples/media-session/audio.html

Best regards Daniel

gorork commented 7 years ago

@kalaspuffar Adding more standalone properties doesn't seem like a good solution. Better, we could add an optional property that consumes object with properties that corresponds to the mediaSession.metadata. This could be called metadata. What do you think?

kalaspuffar commented 7 years ago

Sounds like a great idea. This will be future prof as well. The API may be extended in later releases.