search

gorse-io / gorse

Gorse open source recommender system engine
https://gorse.io
Apache License 2.0
8.62k stars 785 forks source link

Import from csv improvement #746

Closed huaesthetica63 closed 4 days ago

huaesthetica63 commented 1 year ago

Hello! I had some problems with csv-import at Gorse-dashboard. If some of rows are incorrect (my rows had slash-symbol in labels), then import interrupts with error. I think that it would be better if incorrect rows will be just skipped without interrupting import

zhenghaoz commented 1 year ago

Thanks for your suggestions. Skip interruption could be an option in the import UI.

huaesthetica63 commented 1 year ago

Hello again! I can't see any button or checkbox for skipping interruptions. I think that code needs to be changed for this feature.

huaesthetica63 commented 1 year ago

Can I fork your project and add this feature? I will be happy if you allow me this.

zhenghaoz commented 1 year ago

Glad to know that you are interested in it. There are two steps to support interruption skipping:

  1. Add a new option in import UIs on the dashboard: https://github.com/gorse-io/dashboard/blob/master/src/views/ImportFeedback.vue https://github.com/gorse-io/dashboard/blob/master/src/views/ImportItems.vue https://github.com/gorse-io/dashboard/blob/master/src/views/ImportUsers.vue
  2. Pass this option to import APIs: https://github.com/gorse-io/gorse/blob/master/master/rest.go
zhenghaoz commented 4 days ago

This issue could be closed since CSV has been deprecated in #885