goryn-clade / pathfinder-containers

A Docker-compose solution for Pathfinder mapping tool using Traefik
Other
61 stars 66 forks source link

Do a little cleaning #64

Closed ZaxLofful closed 10 months ago

ZaxLofful commented 1 year ago

There are a few inconsistencies in the way code is written and also a volume that isn't needed.

There is also a spacing problem for the .env file, which docker-compose hates

ZaxLofful commented 1 year ago

Hostname only applies to DNS resolution inside the container itself, it doesn't affect the routing of outside networks or other containers.

Setting container_name will set both the name of the container and the Docker Internal DNS routing of all containers to the generic name.

Thus achieving both naming convention and DNS resolution.