search

goryn-clade / pathfinder-containers

A Docker-compose solution for Pathfinder mapping tool using Traefik
Other
61 stars 66 forks source link

Restore fix for bug #23 #66

Closed vlanf closed 10 months ago

vlanf commented 1 year ago

For some reason changes made in docker-compose.yml to fix bug #23 are missing in current master branch.

https://github.com/goryn-clade/pathfinder-containers/pull/38

image

I'm not sure what if the line - ./websocket:/app is necessary, so commented it out. Looking for someone who can investigate why this line was added back then.

I checked this bug fixing on my instance. Without this change map logs are not written. With this change logs are good. But I have not checked if they are logrotated.

ElegosAkla commented 1 year ago

For the ./websocket:/app Look like it's not necessary anymore since the socket come now from " image: ghcr.io/goryn-clade/pf-websocket:latest " before it was build from composer image and the folder "websocket" .

samoneilll commented 10 months ago

@vlanf , thanks, good catch. I'm not sure why this got dropped. looks like it's going to be a pain in the arse to merge your PR alongside some other changes to docker-compose, so I'll just make my own commit.