search

goryn-clade / pathfinder-containers

A Docker-compose solution for Pathfinder mapping tool using Traefik
Other
61 stars 66 forks source link

Update README.md: Fix docker-compose staging CA server line link #70

Closed vlanf closed 10 months ago

vlanf commented 1 year ago

We don't want users to remove - "8080:8080" line :)

TyrHeimdalEVE commented 1 year ago

Linking the documentation to a specific line using master branch is going to cause fuckery when there is changes.

This should optimally be flagged in .env that switches between staging/production LE endpoint, a script that provides the switch, a one-liner replacement with sed instead, or at the very least a permalink/gist in my opinion.

I'm curious though, why are we even exposing port 8080 at all?! 🤔

For safety reasons, it could also be a default false bool flag in .env so the user can choose to expose the traefik dashboard if they wish. Some might have adequate firewalling and end up exposing it unintentionally.

@samoneilll: got some input here?

samoneilll commented 10 months ago

@vlanf I've just removed the link to the specific line, as it's going to change all the time. made an additional comment in docker-compose file to try to make it clearer which line to remove.

@TyrHeimdalEVE port 8080 is open on the PF container to talk to websocket container.