search

gosexy / redis

Redis client for Go that maps the full redis command list into equivalent Go functions.
MIT License
167 stars 44 forks source link

Changed ZUnionStore argument number #2

Closed 22morph closed 11 years ago

22morph commented 11 years ago

ZUnionStore was taking an argument named key which wasn't useful by itself to the command. Now ZUnionStore takes arguments like ZInterstore, just like in redis.

xiam commented 11 years ago

Pull request looks fine, could you please attach a code example of the problem this commit tries to fix?

Thanks,

22morph commented 11 years ago

I made a gist where I explain better the change. But again if this is not the right way to attach code, tell me and I'll fix it. https://gist.github.com/22morph/5059005

xiam commented 11 years ago

Using gist is perfect! but I was referring to a simpler example like:

redisClient.ZUnionStore("a", 2, "b", "c") fails because [...] and now [...].

I just need to be sure I am not missing something before merging, there are some other funcs that may be changed too.

xiam commented 11 years ago

Please re-open if you have demo code. Thanks.