gosexy / redis

Redis client for Go that maps the full redis command list into equivalent Go functions.
MIT License
167 stars 44 forks source link

ConfigGet to return []string #40

Closed tgkavanagh closed 9 years ago

tgkavanagh commented 9 years ago

The original ConfigGet() API returned (string, error) which resulted in an error if the config parameter needed to return an array of values. Therefore modifying the API to return ([]string, error)

tgkavanagh commented 9 years ago

Wondering if these changes are going to be merged into the repo. The first 2 builds failed on a fetch issue (x509 certificate issue) and not a compile error. The final build did succeed so not sure where that leaves these changes.

xiam commented 9 years ago

Hello @tgkavanagh, that is a go1.2 problem with certain SSL configurations. Please keep it open I need to remove those go1.2 tests from travis first and then check this PR, the problem is I changed my dev machine and I currently don't have the project ready to test.

tgkavanagh commented 9 years ago

@xiam thanks for the update. I will keep this open until you have a chance to retest.

xiam commented 9 years ago

Thanks @tgkavanagh

tgkavanagh commented 9 years ago

@xiam, glad to help.