feat: Add support to allow alternate WebAPI Fetch implementation

agrohs commented 5 years ago

Type

Feature

Implements a new feature

Description

A brief description of the goals of the pull request.

Allows Fetch to be passed into Shippo configuration for custom implementation that matches WebAPI spec to be used for calls to API. This allows alternate/compliant implementations of the Fetch (https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API) spec to be used.

    var shippo = require('shippo')('<YOUR_PRIVATE_KEY>', [
      { Fetch: myCustomWebAPIfetch }
    ]);

Dependencies

Other PRs or builds that this PR depends on.

N/A

Issues

A list of issues closed by this PR.

N/A

Notes

Ex. - a scenario where you want to proxy the request to avoid exposing <YOUR_PRIVATE_KEY> in any requests.

agrohs commented 5 years ago

@mootrichard, @glsoda - just checking the status of this repository to see if its still being maintained/still accepting PRs and/or happy to offer any help maintaining if needed.

Cheers!

mootrichard commented 5 years ago

@agrohs I am no longer a maintainer on this repo. @simonkreuz is one of the founders, and would hopefully be able to get someone's eyes on it from his team.

agrohs commented 5 years ago

Thanks @mootrichard (and hello @simonkreuz). Let me know if this repo is still active and if any questions/changes needed to merge the PR?

smkrz commented 5 years ago

@agrohs - yes the repo is still active, but we're a bit understaffed on node developers. I'm working with the team and will provide another update shortly. Thanks for your patience.

agrohs commented 5 years ago

Sounds great, no worries at all!

(and offer still stands any time if you need an extra contributor/pair of eyes as part of the team on the repo to handle any reviews/merges and such)

smkrz commented 5 years ago

@agrohs - quick update: we're on this, but it's unfortunately taking a bit longer. Thanks for your patience. I hope to have an actual update this week.

agrohs commented 5 years ago

No worries at all @simonkreuz, I appreciate the update!

On Apr 1, 2019, at 7:43 PM, Simon Kreuz notifications@github.com wrote:

@agrohs https://github.com/agrohs - quick update: we're on this, but it's unfortunately taking a bit longer. Thanks for your patience. I hope to have an actual update this week.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/goshippo/shippo-node-client/pull/50#issuecomment-478798432, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJzh79Ft1WUkUglS_ERRtZK7SppZ83Jks5vcqeugaJpZM4b4gHe.

agrohs commented 5 years ago

Just checking back in on here to see if any comments/questions/help needed?

agrohs commented 5 years ago

@simonkreuz, just following up to see if any changes needed in here/any questions at all? we have a launch coming up that has been using our forked version of it for some time and ideally would love to get this PR merged before then if at all possible?

malcolmrebughini commented 5 years ago

Hi @agrohs. I would like to know a bit more about the use case for this.

Do you have a custom fetch implementation server side? Or is this for client side usage?

Thanks.

agrohs commented 5 years ago

We are actually using a custom fetch implementation to send it to a secure proxy that stores our secret keys and replaces them in the headers when it proxies along. For testing purposes though, can be as simple as wanting to use one of the many node fetch implementations out there (cross-fetch, fetch-everywhere, etc.) which are isomorphic and support either client or server side calls. The concept in general is just to let someone be able to plug their preferred library/implementation in to be able to handle API calls. There are a number of other libraries out there that support this concept - happy to share some examples if you’d like!

On Apr 18, 2019, at 3:52 PM, Malcolm Rebughini notifications@github.com wrote:

Hi @agrohs https://github.com/agrohs. I would like to know a bit more about the use case for this.

Do you have a custom fetch implementation server side? Or is this for client side usage?

Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/goshippo/shippo-node-client/pull/50#issuecomment-484685810, or mute the thread https://github.com/notifications/unsubscribe-auth/AABHHBYNELRA2KGJDDXB2O3PRDNQRANCNFSM4G7CAHPA.

agrohs commented 5 years ago

Just checking back in on here?

agrohs commented 5 years ago

Just touching base again to see if any input needed on here/any movement/any plans to merge the PR?

goshippo / shippo-node-client