Bump requests >= 2.21.0, <= 2.24.0 and simple_json >= 3.16.0, <= 3.17.2

goshippo / shippo-python-client

Shipping API Python library (USPS, FedEx, UPS and more)

https://goshippo.com/docs

MIT License

123 stars 70 forks source link

Bump requests >= 2.21.0, <= 2.24.0 and simple_json >= 3.16.0, <= 3.17.2 #65

Closed TysonRV closed 3 years ago

TysonRV commented 3 years ago

Increase range for requests and simple_json libraries, as right now it supports just one version of each and this tends to cause incompatibilities with other libraries.

Testing this with different requests and simple_json versions was satisfactory.

Fixes #64

TysonRV commented 3 years ago

Builds seem to be missing a valid API key... I can see they have been failing for a while now

nickbaum commented 3 years ago

As of today, Shippo's Python library is incompatible with Amazon's boto library that is used for accessing all of AWS.

Shippo hardcodes requests 2.21
Requests 2.21 requires urllib3 <= 1.25
Boto requires urllib3 >=1.25.4

This would be solved by merging this PR.

More broadly, there's a tension between minimizing breakage:

due to breaking changes in minor version releases
due to dependency incompatibilities with other libraries

Certainly for a well-maintained library like requests, I'd recommend erring towards a more lenient version specification until/unless you've experienced actual issues with minor upgrades.

PS: Thanks @TysonRV for the PR!

jfriedr commented 3 years ago

Thanks for the PR!

@TysonRV If you could please ~redact~ get rid of the inclusions of the .gitignore file and the unused imports in setup.py. Once that's changed I'd be happy to get this included and pushed to pypi later today.

@nickbaum thanks for elaborating.

TysonRV commented 3 years ago

@jfriedr That's no problem, I'll just drop the commits. Can I ask what's the motivation behind getting rid of those changes? Is it to keep the PR as clean as possible?

Thanks!

nickbaum commented 3 years ago

Haha, @TysonRV, you beat me to it!

TysonRV commented 3 years ago

@nickbaum Oh, didn't even see it sorry! 😅

jfriedr commented 3 years ago

@TysonRV @nickbaum I've pushed the update to pypi. Thanks again for the pull request(s) and context surrounding the dependencies.

https://pypi.org/project/shippo/#history

nickbaum commented 3 years ago

🎉 Thanks to all for getting this resolved!