search

goshippo / shippo-python-sdk

MIT License
11 stars 1 forks source link

SDKError is raised when a Shippo Account is successfully created #62

Closed tarikozket closed 6 months ago

tarikozket commented 6 months ago

https://github.com/goshippo/shippo-python-sdk/blob/c26003ab931a99c2a7426a9635a39dfb085efa61/src/shippo/shippo_accounts.py#L138

This line should expect a 201 status code instead of 200 since the create method's HTTP response code is 201. Currently, this condition is causing the SDK to raise an SDKError with the error message below:

https://github.com/goshippo/shippo-python-sdk/blob/c26003ab931a99c2a7426a9635a39dfb085efa61/src/shippo/shippo_accounts.py#L149

shippo-lueders commented 6 months ago

fixed in https://pypi.org/project/shippo/3.4.3/

tarikozket commented 6 months ago

@shippo-lueders thank you, Mike!