search

goshippo / shippo-ruby-client

Shipping API Ruby library (USPS, FedEx, UPS and more)
https://goshippo.com/docs/
76 stars 72 forks source link

Allow setting token per request #74

Closed laurynas closed 6 years ago

laurynas commented 7 years ago

It allows using multiple accounts in the single service/application.

theinventor commented 7 years ago

Hey all - whats the status on this PR?

mootrichard commented 7 years ago

I've created a ticket internally to get one of our engineers to take a look at this as soon as they can.

bryanaka commented 6 years ago

Thanks for the contribution @laurynas and the review @oehlschl and sorry about the long lead time.

I feel good about merging this PR. I just want to merge #80 first and then re-run against the new versions added to the build. I will confer with my coworker about the release process next week and then will merge

bryanaka commented 6 years ago

@laurynas do you mind rebasing on master? If it passes on the new travis config, we will go ahead and merge this and bump the minor version.

laurynas commented 6 years ago

Hi @bryanaka, rebased on master.

bryanaka commented 6 years ago

awesome, thanks @laurynas - I will ping this thread again once published to Rubygems

axlekb commented 5 years ago

Never published to Rubygems! 😢

And no one appears to work at Shippo anymore. 😢x2.

Anyone at Shippo still watch this project? Seems worthy for a new version even though it's 18 months later!

From checking out Meet the Team, I'll try to tag some folks: @assislucas @sinmeitsai

🤞

mootrichard commented 5 years ago

I don't work at Shippo anymore, but I saw the notification. Including @simonkreuz, as well for visibility.

mykewould commented 5 years ago

@axlekb I'll be taking a look at getting a new version published. No ETA at the moment, but I'll update here by end of day tomorrow at the latest.

mykewould commented 5 years ago

We're working through some specs that began failing since the last release. We're also patching some low-hanging issues. New release should be out in the next week or so.

https://github.com/goshippo/shippo-ruby-client/pull/89

axlekb commented 5 years ago

Thanks for the update, @mykewould. I had to peg rest-client at 2.0.2 to get my own specs to pass after new errors were introduced with `2.1.0. Not sure if that helps your debugging or not.

mykewould commented 5 years ago

I appreciate that @axlekb. Looks like the issue is related to VCR and how it stores/reads compressed responses into/from binary. Something in the dependency tree changed at some point, although its not gem related, as you can see in https://github.com/goshippo/shippo-ruby-client/pull/89 the only thing thats changed is text in the CHANGELOG.md and the tests (which were otherwise passing) now fail.

I think the simple next step is to rerecord those cassettes. I'll update if that doesn't end up being the fix.

I've also bumped the version of rest-client in PR https://github.com/goshippo/shippo-ruby-client/pull/91 in response to your concern and issue #88