search

goshuirc / bnc

a simple irc bouncer written in go
https://goshubnc.org/
MIT License
17 stars 3 forks source link

Send NAMES upstream when dumping channels as some clients expect NAME… #12

Closed prawnsalad closed 7 years ago

prawnsalad commented 7 years ago

…S to be automatic

DanielOaks commented 7 years ago

Note to self: take a look at #10 as well with this. I think that this change looks correct – getting names sent to listeners makes sense (could manually construct the NAMES messages ourselves if we really wanted to though) – but because of #10 we're likely not joining the channels as we're supposed to anyways.

prawnsalad commented 7 years ago

Constructing the NAMES messages ourselves would involve keeping track of user lists which could 1) get memory hungry if there are many BNC users, and 2) be a lot more work than just sending NAMES upstream which does the same job.

DanielOaks commented 7 years ago

Makes sense, I'll just leave it as it is here for now in that case

DanielOaks commented 7 years ago

Merged into master, thanks!