search

gosimple / slug

URL-friendly slugify with multiple languages support.
Mozilla Public License 2.0
1.15k stars 108 forks source link

Substitute @ with at in german #46

Closed kunzese closed 3 years ago

kunzese commented 4 years ago

I would suggest replacing the character @ with at. To be honest, I've never heard anyone say "xyz AN gmail.com" while providing their email address.

codecov[bot] commented 4 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #46   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          84     84           
=====================================
  Hits           84     84
Impacted Files Coverage Δ
languages_substitution.go 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8535650...b9eda37. Read the comment docs.

kunzese commented 4 years ago

@matrixik Any updates on this PR?

kunzese commented 3 years ago

I am closing this pull request because I have not received any feedback since 2019-12-17.