search

gosimple / slug

URL-friendly slugify with multiple languages support.
Mozilla Public License 2.0
1.17k stars 109 forks source link

Code panics for Unicode U+10000 #53

Closed tja closed 3 years ago

tja commented 3 years ago

This code panics:

slug.Make("𐀀")

This is due to the internal use of rainycape/unidecode, which can not handle Unicode character U+10000, see https://github.com/rainycape/unidecode/issues/8.

Given the inactivity of the upstream package, it might be worth filtering out the character in question before passing it to unidecode.

matrixik commented 3 years ago

Thank you for this report and sorry it took so long, burnout is not nice...

I forked https://github.com/rainycape/unidecode to https://github.com/gosimple/unidecode and fixed this issue.

tja commented 3 years ago

Thanks a bunch for the fix.. I really appreciate it.

Sorry to hear about your burnout — I hope you're doing better now!

matrixik commented 3 years ago

I'm definitely better now, thank you.