search

gosquared / redis-clustr

Redis Cluster client for Node.js
MIT License
107 stars 25 forks source link

Added benchmarks and changed 'double-ended-queue' to 'denque' - small perf increase. #16

Closed Salakar closed 7 years ago

Salakar commented 7 years ago

Recently wrote a faster double ended queue implementation here - I've switched out the 'double-ended-queue' dependency for this as it's considerably faster (maintains compatibility with api and node versions and 100% coverage - so nothings changed there)

(and added benchmarks in the process) \o/

Before switch

image 

After switching to 'denque'

image

Ran the benchmarks several times, with denque is always faster. Couple of other performance tweaks that can be done on this repo - but i'll do a separate PR for that.

jbt commented 7 years ago

Hi @Salakar sorry I just realised I completely forgot to reply over on Gitter. This is awesome, thanks for putting this PR together! Travis seems happy, so I'll just check this quickly myself and then get this out as 1.5.2

Salakar commented 7 years ago

@jbt no worries, I should've done a PR in the first place ;p

jbt commented 7 years ago

Merged and published as 1.5.2, thanks @Salakar! :+1: