Rename binaries to strip '-alpha'

goss-org / goss

Quick and Easy server testing/validation

https://goss.rocks

Apache License 2.0

5.57k stars 472 forks source link

Rename binaries to strip '-alpha' #671

Closed petemounce closed 3 years ago

petemounce commented 3 years ago

Checklist

[x] make test-all (UNIX) passes. CI will also test this
[x] unit and/or integration tests are included (if applicable)
[x] documentation is changed or added (if applicable)

Description of change

As discussed in https://github.com/aelsabbahy/goss/pull/663#issuecomment-743127235; strip the -alpha naming, keep the messaging, keep the --use-alpha flag and env-var.

We're reasonably comfortable with the current situation - nothing seems to be horrendously broken in terms of the ported functionality as exercised by the added macOS & Windows integration tests, and based on Improbable's use (that I am intimately familiar with).

This change allows people to remove edge-cases from their installation, yet retains the clearly-set expectations of support being community-driven.

Fixes #651. Continues #663.

Note: this is aimed at v4.

petemounce commented 3 years ago

@aelsabbahy I think this is ready to review; I'm just waiting for linux CI to pass. I expect it to, but then, I always expect it to... ;-)

aelsabbahy commented 3 years ago

Awesome timing on this.. I'm really really hoping to have v4 released soon. Doing last-minute merges of breaking features and of-course there's going to be a massive rebase of the transform branch.. hopefully, it's good to go after that!

aelsabbahy commented 3 years ago

Quick eyeball check on this looks good.. plus CI passed.

Any idea why codeclimate didn't trigger? I assume none of your changes messed with that.

I'll wait for your answer on codeclimate and merge.. If you didn't change anything, don't worry about why it's not working.. just let me know and I'll merge anyways. =)

petemounce commented 3 years ago

Quick eyeball check on this looks good.. plus CI passed.

Any idea why codeclimate didn't trigger? I assume none of your changes messed with that.

I'll wait for your answer on codeclimate and merge.. If you didn't change anything, don't worry about why it's not working.. just let me know and I'll merge anyways. =)

The only thing that springs to mind about codeclimate is maybe it's only configured to trigger against branches aimed at master, or only against branches aimed at protected branches?

aelsabbahy commented 3 years ago

The only thing that springs to mind about codeclimate is maybe it's only configured to trigger against branches aimed at master, or only against branches aimed at protected branches?

Yup, that's my guess too.. just wanted to check you didn't knowingly change anything to impact this.

Related note, I may get rid of codeclimate, or at least run it against the official Go codebase and see how many findings come up. If Official Go codebase fails, then I'm not interested in codeclimate. Also, need to actually have golint fail the build and fix all those findings.

Thanks for the PR, love the cleanups!