search

goss-org / goss

Quick and Easy server testing/validation
https://goss.rocks
Apache License 2.0
5.57k stars 472 forks source link

Make tmp dir configurable in dcgoss #689

Closed TheLastProject closed 2 years ago

TheLastProject commented 3 years ago
Checklist

Description of change

This is useful when running in CI and wanting to save the container output as a job artifact under environments where uploading outside of the build directory is not allowed (such as on GitLab CI).

Similar to #329 and provides an easier workaround (although not a fix) to #624, but only for dcgoss, not dgoss. It would be fairly trivial to apply this patch to dgoss too but I have only use for dcgoss so I only tested this for dcgoss.

The build failure seems unrelated to my change.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

TheLastProject commented 3 years ago

Uhm... I'm still waiting for the dev to respond to this?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

TheLastProject commented 3 years ago

Still waiting on the dev...

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

TheLastProject commented 2 years ago

Still waiting

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

aelsabbahy commented 1 year ago

Thank you for taking the time to submit this. I apologize for the long delay, I am going through the stalebot closed issues and reviving them over the next few weeks.

Since dcgoss is community supported @fbartels @frederikbosch I would love your feedback.

PS: I am unable to reopen this issue as the submitter repository seems to have been deleted.

TheLastProject commented 1 year ago

I have to state that I no longer work at the place I wrote this patch for and haven't had access to any codebase using goss for quite some months so I can't personally check anything related to this code anymore. All I can say is that I did test this before submitting it here and didn't notice any issues. So I am afraid you are kinda "on your own" for this patch if you still want to look at it.

fbartels commented 1 year ago

I have to say that I am currently not using dcgoss either (only goss itself), but the change seems sane to me from a bash perspective.

aelsabbahy commented 1 year ago

Thank you both for clarifying.

Given the history of dcgoss https://github.com/aelsabbahy/goss/pull/427#issuecomment-477683147, and the fact that it's for inspirational purposes, I'll leave it as is.

If others start using dcgoss and feel that it's important for them to have this feature they can resubmit it.

@fbartels I'll stop tagging you on PRs for dcgoss so I'm not spamming you 😅

fbartels commented 1 year ago

I'm glad to help