goss-org / goss

Quick and Easy server testing/validation
https://goss.rocks
Apache License 2.0
5.57k stars 472 forks source link

improvements to gossfile configuration format #696

Closed sshipway closed 3 years ago

sshipway commented 3 years ago

Describe the feature: Currently, the way to define included gossfiles feels inflexible and inconsistent. I would like to improve this while retaining backwards compatibility with the existing configuration format.

Describe the solution you'd like Currently, we use this format to inclue a gossfile:

gossfile:
  goss_httpd.yaml: {}

I would like this to have optional attributes, so that it can be expressed as:

gossfile:
  xxxxx:
    file: goss_httpd.yaml
    skip: false

The file attribute would override the keyval as the filename/wildcard to be included. The optional skip attribute would allow this include to be disabled (as with other skip attributes on other resource types)

Describe alternatives you've considered The current method works, but is awkward if you want to use skip to disable a whole gossfile rather than a single resource. Also, having the filename in the keyval rather than as an attribute can make for some large and unweildy keyvals

sshipway commented 3 years ago

I have a created pull request for this in #697

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sshipway commented 3 years ago

-bump-

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

aelsabbahy commented 1 year ago

Closed by #697