Support for linux/arm64 architecture

goss-org / goss

Quick and Easy server testing/validation

https://goss.rocks

Apache License 2.0

5.55k stars 473 forks source link

Support for linux/arm64 architecture #722

Closed tnaroska closed 2 years ago

tnaroska commented 2 years ago

Describe the feature: Goss currently provides 32bit arm binaries in the release but not arm64.

Describe the solution you'd like

add linux arm64 to the supported architectures
provide binary builds for arm64 in the GitHub release page

Describe alternatives you've considered

sync codebase and build myself. But it’s more desirable to get all binaries out of the official build pipeline.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

linki commented 2 years ago

@tnaroska I created a PR for an arm64 release here. I would like to hear your thoughts on this.

tnaroska commented 2 years ago

Thanks for working on this @linki ! PR looks good to me. My use case is AWS Graviton/Apple M1 only, so I cannot comment on the 32-bit arm part in install.sh.

smwltr commented 2 years ago

@linki Is there anything I can do to help? Do you need some testing done?

I was able to build it with some issues.

linki commented 2 years ago

@smwltr I just simplified https://github.com/aelsabbahy/goss/pull/737 and we can hopefully merge this soon. If you can test the resulting goss-linux-arm (should be 32-bit) and goss-linux-arm64 (should be 64-bit) after we merged the PR, then that would be great.

If you have access to a 32-bit arm machine you could check its output for uname -m and we could add it to the if statement in https://github.com/aelsabbahy/goss/pull/756. Or if you're certain about the other possible values we could also just add them without confirming first.

smwltr commented 2 years ago

@linki I only have access to ARM64 machines, which gives: aarch64