Closed thrix closed 2 years ago
I would suggest the default continues to be docker. Those that want to use podman can set CONTAINER_RUNTIME
to override.
Changing the default would be a breaking change for dgoss consumers that happen to have podman installed.
@ekelali ack, let's mitigate breaking changes
@ekelali it should be resolved
@aelsabbahy hi, do you think we could get this in, or should I do some more changes?
Sorry, the travis-ci OSS credits ran out again, I had to open up a support ticket. To get the job to trigger, I had to close/reopen the issue.
Checklist
make test-all
(UNIX) passes. CI will also test thisDescription of change
If
podman
is available on the host, let's use it instead ofdocker
. Podman does not need a daemon to run and is common in RHEL-like OSes.To be able to use
podman
as the container backendpodman run
needs to run a command which does not finish. Commonlysleep infinity
is used for that.Provide enough documentation to understand the feature for the users.
I believe keeping just one command
dgoss
is a better approach, let's not complicate things for users.Partially resolves #507