search

goss-org / goss

Quick and Easy server testing/validation
https://goss.rocks
Apache License 2.0
5.5k stars 470 forks source link

Add JSON schema to schemastore.org for integration into VSCode #811

Open lox opened 1 year ago

lox commented 1 year ago

Describe the feature:

Since there is now a JSON schema (https://github.com/goss-org/goss/pull/793) would be great to have it mapped to goss.yml files via Schema Store. This would mean that folks using editor plugins like https://github.com/redhat-developer/vscode-yaml would immediately get validation for their goss files.

Describe the solution you'd like Reference the JSON Schema via https://github.com/SchemaStore/schemastore/blob/master/CONTRIBUTING.md#catalog (happy to do this if there is interest)

Describe alternatives you've considered Manual editor configuration.

aelsabbahy commented 1 year ago

@gberche-orange and @ripienaar any thoughts on this?

@lox for my own clarity, it seems the actual PR would be to the schemastore repo, not Goss, correct? Or is there something needed to be also done here.

ripienaar commented 1 year ago

This would be a great addition.

aelsabbahy commented 11 months ago

Heads up, v0.4.0 release candidate just went out. It may impact some of the schemas that were written up.

Please let me know if you have any questions.

gberche-orange commented 11 months ago

thanks @aelsabbahy ! I'll try updating the json schema against https://github.com/goss-org/goss/releases/tag/v0.4.0-rc.1 and propose a unit tests for future regressions in goss-org/goss, either this week or more likely early September when I some available time. Anyone feel free to tackle this earlier if some bandwidth is available earlier. After that, we can get a PR on schemastore, possibly versioned if there is need to account for breaking changes in syntax in 0.4