Address a few shellcheck complaints about dgoss

goss-org / goss

Quick and Easy server testing/validation

https://goss.rocks

Apache License 2.0

5.58k stars 470 forks source link

Closed mdb closed 1 year ago

mdb commented 1 year ago

👋 Hello - this addresses a few shellcheck complaints with dgoss.

double quote variables to prevent globbing and wordsplitting: https://www.shellcheck.net/wiki/SC2086
use -n instead of ! -z: https://www.shellcheck.net/wiki/SC2236

aelsabbahy commented 1 year ago

Eyeball check looks good. Will run validate it locally and merge soon.

Thank you for this contribution.

aelsabbahy commented 1 year ago

Thank you for the contribution, much appreciated!