Fix release-build.sh for macOS

goss-org / goss

Quick and Easy server testing/validation

https://goss.rocks

Apache License 2.0

5.5k stars 470 forks source link

Fix release-build.sh for macOS #828

Closed matsuo closed 11 months ago

matsuo commented 11 months ago

Checklist

[x] make test-all (UNIX) passes. CI will also test this

Description of change

This pull request fixes release-build.sh to run "make build" on macOS.

On macOS, "make build" failed because there is no sha256sum command in the default environment.

% sw_vers 
ProductName:        macOS
ProductVersion:     13.5
BuildVersion:       22G74
% make build    
./release-build.sh alpha-darwin-amd64
./release-build.sh: line 39: sha256sum: command not found
make: *** [release/goss-alpha-darwin-amd64] Error 127

aelsabbahy commented 11 months ago

Great catch, didn't notice that MacOS was missing from the RC.

Thank you for the contribution!

matsuo commented 11 months ago

Thank you for your quick confirmation!

aelsabbahy commented 11 months ago

Hmm, seems like there are still no osx binaries in the latest release.

@petemounce I think you were involved in some of those scripts. Any idea why osx might be failing?

matsuo commented 11 months ago

@aelsabbahy I believe I may have found the cause. Please check #829.