Added ctx object to all system struct's constructors - Githubissues

goss-org / goss

Quick and Easy server testing/validation

https://goss.rocks

Apache License 2.0

5.5k stars 470 forks source link

Added ctx object to all system struct's constructors #837

Closed aelsabbahy closed 9 months ago

aelsabbahy commented 10 months ago

The idea behind this commit is to set the stage for adding additional logging metadata.

Added logging support for command as an example.

Checklist

[ ] make test-all (UNIX) passes. CI will also test this
[ ] unit and/or integration tests are included (if applicable)
[ ] documentation is changed or added (if applicable)

Description of change

This is the simpler version of #836 it goes against the guidance here but it is a much simpler (and cleaner?) implementation.

Also, this approach didn't break any of the unit tests, like #836 did.

aelsabbahy commented 9 months ago

Seems a bit of work piled up, going to start merging it.. since it's internal to the app we can revisit/change in a future PR.