Closed aelsabbahy closed 9 months ago
CC: @obourdon, @ripienaar,@plannigan, @GhuulCZ
Since you all have been involved with discussions around this.
Seems reasonable to me. :+1:
My preference would have been to actually error, this is much better than silently overwriting.
@plannigan how about a layered approach
--log-level ERROR
to silence warnings.. perhaps they're intentionally using overrides. (This pr)--strict
(new pr)Yeah, that makes sense. Default to showing the warning. People can silence it if they want. People can also elevate it to an error if they want.
Checklist
make test-all
(UNIX) passes. CI will also test thisDescription of change
Prints out warning messages when overlapping keys are detected, for example:
goss.yaml:
goss_embed.yaml:
Same with render:
This warning is printed for both failing and passing tests, essentially it is informing the user that the tests were overwritten.. which may or may not be desired.
As a consequence of this change, I moved some existing log levels around to match what I would expect as a user:
TRACE
- Detailed internal system activities useful for goss developers to debug.DEBUG
- Information useful for the goss user to debug.INFO
- General operational messages, useful for tasks where a more structured output is needed (e.g.goss serve
).WARN
- Non-critical issues that may require attention, such as overwritten keys or deprecated features.closes #743
Questions
-l warn
or-l error