Closed sebhoss closed 6 months ago
pinging @petemounce @timeu since you guys were involved in the original implementation
From my point of view it looks good. Thanks for the fix
Merging based on @timeu review.
Thank you for the great contribution @sebhoss
Thanks everyone!
The prometheus metric goss_tests_run_outcomes_total has a label called 'outcome' which suffers from two problems:
This commit fixes both by introducing a helper function which determines whether the outcome can be changed and adds tests to verify that behavior.
fixes #789
Checklist
make test-all
(UNIX) passes. CI will also test thisDescription of change