feat: s390x build option added to build package for IBM Z series

goss-org / goss

Quick and Easy server testing/validation

https://goss.rocks

Apache License 2.0

5.5k stars 470 forks source link

feat: s390x build option added to build package for IBM Z series #863

Closed harpaldhillon closed 5 months ago

harpaldhillon commented 5 months ago

A new build option (release/goss-linux-s390x) is added in the Makefile to release package for s390x architecture.

Checklist

[x] make test-all (UNIX) passes. CI will also test this
[x] unit and/or integration tests are included (if applicable)
[x] documentation is changed or added (if applicable)

Description of change

A new build option (release/goss-linux-s390x) is added in the Makefile to release package for s390x architecture.

aelsabbahy commented 5 months ago

Sorry for the delay, I recently had a newborn so been busy.

This looks good, just need to update the .travis.yaml to ensure those binaries are published as part of the release.

For my own education/growth, do all goss features work out the box for s390x? or does it only partially work? Wondering if it should be a standard release or something in the multi-os support section.

harpaldhillon commented 5 months ago

Many congratulations @aelsabbahy on your newborn baby.

Thanks, changes are now pushed to .travis.yaml file.

Also, we run around 175 goss tests based on CIS benchmarks and all these successfully passed on s390x machine. I think it can be part of standard release.