[x] make test-all (UNIX) passes. CI will also test this
[x] unit and/or integration tests are included (if applicable)
[x] documentation is changed or added (if applicable)
Description of change
This adds a resource_id label to each test-specific metric if the verbose format option was enabled. This assumes that the combination of resource ID and resource type is unique.
Since we only have access to format options in the Output method, we are creating metrics during the first run of that method.
Metrics can only be registered once for any given set of labels, so we create a custom registry and use the existence of that as a check whether we need to create/register metrics. This has the added benefit of simplifying the test a tiny bit, and it exposes even less metrics on the /healthz endpoint.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
This adds a
resource_idlabel to each test-specific metric if theverboseformat option was enabled. This assumes that the combination of resource ID and resource type is unique.Since we only have access to format options in the
Outputmethod, we are creating metrics during the first run of that method.Metrics can only be registered once for any given set of labels, so we create a custom registry and use the existence of that as a check whether we need to create/register metrics. This has the added benefit of simplifying the test a tiny bit, and it exposes even less metrics on the /healthz endpoint.
fixes #862
Pinging @petemounce @aelsabbahy