goss-org / goss

Quick and Easy server testing/validation
https://goss.rocks
Apache License 2.0
5.5k stars 470 forks source link

install.sh: Install latest release #878

Closed jkirk closed 3 months ago

jkirk commented 4 months ago

https://github.com/goss-org/goss/blob/e73553f9c3065ac297499dafb4f8abef6acb24ad/install.sh#L8

Shouldn't this line read LATEST_EFFECTIVE=https://github.com/goss-org/goss/releases/tag/v0.4.4?

aelsabbahy commented 4 months ago

You are correct, it should use the commented out code that resolves the latest version.

Feel free to submit a PR and I can merge it later this week. Otherwise, I can get around to it in 1-2 weeks time.

I think I initially hardcoded 3.x to avoid the automated upgrade to the breaking 4.x release.. but at this point enough time has passed that it's fine to update the script. Great catch, completely missed this!