Closed dklimpel closed 1 week ago
So is this essentially a replacement for: https://github.com/aelsabbahy/goss-docker
Btw.. many thanks for the awesome work you've submitted! These are all great improvements.
Added a small question, and might be helpful to add some documentation to this PR (can be minimal). Otherwise, it seems ready to merge
Did you mean this kind of documentation? Or something to the GH pipeline?
Did you mean this kind of documentation? Or something to the GH pipeline?
Yup, this looks great!
I will have a look why it is failing. I had tested it successfully.
In my repo I have not problems and it works. But I cannot see the package in goss Repo: https://github.com/orgs/goss-org/packages?repo_name=goss
Perhaps GH needs some time to activate.
It seems that permissions have to set there for the package: https://docs.github.com/en/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility
Yeah it's set to private, but I can't set it to public due to org settings. I'll take a look at it sometime in the next couple of days.
https://github.com/goss-org/goss/pkgs/container/goss
Done, was pretty simple actually.
Checklist
make test-all
(UNIX) passes. CI will also test thisDescription of change
Add building own docker image and upload to ghcr.io. Realted image: https://github.com/aelsabbahy/goss-docker/blob/master/Dockerfile
Build image from
<latest-tag>-master+<short commit sha>
(semantic version)<tag>
Add CVE scan to github security page
Related to:
901