goss-org / goss

Quick and Easy server testing/validation
https://goss.rocks
Apache License 2.0
5.5k stars 470 forks source link

Add pipeline for build goss docker image #909

Closed dklimpel closed 1 week ago

dklimpel commented 1 month ago
Checklist

Description of change

Add building own docker image and upload to ghcr.io. Realted image: https://github.com/aelsabbahy/goss-docker/blob/master/Dockerfile

Build image from

Add CVE scan to github security page

Related to:

aelsabbahy commented 2 weeks ago

So is this essentially a replacement for: https://github.com/aelsabbahy/goss-docker

Btw.. many thanks for the awesome work you've submitted! These are all great improvements.

dklimpel commented 1 week ago

Added a small question, and might be helpful to add some documentation to this PR (can be minimal). Otherwise, it seems ready to merge

Did you mean this kind of documentation? Or something to the GH pipeline?

aelsabbahy commented 1 week ago

Did you mean this kind of documentation? Or something to the GH pipeline?

Yup, this looks great!

dklimpel commented 1 week ago

I will have a look why it is failing. I had tested it successfully.

dklimpel commented 1 week ago

In my repo I have not problems and it works. But I cannot see the package in goss Repo: https://github.com/orgs/goss-org/packages?repo_name=goss

Perhaps GH needs some time to activate.

dklimpel commented 1 week ago

It seems that permissions have to set there for the package: https://docs.github.com/en/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility

aelsabbahy commented 5 days ago

Yeah it's set to private, but I can't set it to public due to org settings. I'll take a look at it sometime in the next couple of days.

aelsabbahy commented 5 days ago

https://github.com/goss-org/goss/pkgs/container/goss

Done, was pretty simple actually.