search

goss-org / goss

Quick and Easy server testing/validation
https://goss.rocks
Apache License 2.0
5.5k stars 470 forks source link

Missing dgoss sha256 asset for release v0.4.7 #914

Open dklimpel opened 1 month ago

dklimpel commented 1 month ago

Describe the bug

The sha256 checksum (dgoss.sha256) is missing in the assets for release v0.4.7

How To Reproduce

An checksum asset (dgoss.sha256). Either added afterwards or for the next release.

Actual Behavior

Its' missing

Environment:

By the way, there is a release for dgoss, bot not for kgoss and dcgoss.

aelsabbahy commented 1 month ago

By the way, there is a release for dgoss, bot not for kgoss and dcgoss.

Yeah it's a bit tricky, dgoss I maintain, everything else is community added/supported, but I don't maintain it, but I guess technically that's the case with windows/macos too and that's now in releases. 🤔

Also, I think the install.sh installs dgoss from the latest version in git. I think that decision was based on not wanting to cut a Goss release for a minor bash wrapper script change.

Perhaps the whole release lifecycle needs to be re-evaluted l:

  1. What changes trigger a release.
  2. What is considered part of a Goss release
  3. BONUS: Improve installation story for Linux and other OSes
dklimpel commented 1 month ago

Yeah it's a bit tricky, dgoss I maintain, everything else is community added/supported, but I don't maintain it.

This makes it clearer.

Than I have added to much changes to:

aelsabbahy commented 1 month ago

It's fine, we can keep them for now.

Before, I didn't release what I didn't maintain, but that changed with windows/macOS support.. so might as well release dcgoss/kgoss.