disable deprecated codeclimate plugin golint - Githubissues

goss-org / goss

Quick and Easy server testing/validation

https://goss.rocks

Apache License 2.0

5.5k stars 470 forks source link

disable deprecated codeclimate plugin golint #927

Closed dklimpel closed 2 weeks ago

dklimpel commented 3 weeks ago

Checklist

[x] make test-all (UNIX) passes. CI will also test this
[x] unit and/or integration tests are included (if applicable)
[x] documentation is changed or added (if applicable)

Description of change

The plugin is deprecated: https://docs.codeclimate.com/docs/golint
And it reports errors: https://codeclimate.com/github/aelsabbahy/goss/builds/693

I have not seen an alternative for this plugin.

Reported error/line: https://github.com/goss-org/goss/blob/6a8fc9623d846e4b9093fde7f9685e6abcc21457/goss_config.go#L114

aelsabbahy commented 2 weeks ago

Same question as other PR, does code climate offer any additional value at this point?

I feel it was added many years back and then ignored 😅

dklimpel commented 2 weeks ago

I feel it was added many years back and then ignored

If you do not used this, it can be removed in feature.