search

gost-engine / engine

A reference implementation of the Russian GOST crypto algorithms for OpenSSL
Apache License 2.0
379 stars 174 forks source link

adapt tests for openssl crl/req exit code on verification failure #452

Closed vladak closed 8 months ago

vladak commented 8 months ago

In PR https://github.com/openssl/openssl/pull/23773 I am about to change the exit code used by the openssl req and openssl crl commands on verification failure. This will likely be part of OpenSSL 3.3.x. Some of the gost-engine tests expect the exit code on verification failure to be 0. These have to be adapted to the new behavior.

vt-alt commented 8 months ago

Thanks for the heads up. Will look at this on weekend.

vt-alt commented 8 months ago

I introduced the test suite change that should make tests pass with and without your PR.

ps. Amended the commit because I thought verify failure message is always on stderr but it wasn't.