search

gostevehoward / confseq

Confidence sequences and uniform boundaries
MIT License
54 stars 3 forks source link

Needed to include the memory library to use std::shared_ptr #1

Closed WannabeSmith closed 4 years ago

WannabeSmith commented 4 years ago
WannabeSmith commented 4 years ago

Whoops. Trying to merge into my fork!

gostevehoward commented 4 years ago

I hadn't indicated anything about style in the README, but since you'll be contributing, I'd like to follow the Google C++ style guide as much as possible. I can't say I know the whole thing, but I've tried to follow it myself. In particular, you should keep lines to 80 chars max---that is important. They also suggest ordering includes alphabetically, which I've tried to follow, though that isn't as important.

WannabeSmith commented 4 years ago

I hadn't indicated anything about style in the README, but since you'll be contributing, I'd like to follow the Google C++ style guide as much as possible. I can't say I know the whole thing, but I've tried to follow it myself. In particular, you should keep lines to 80 chars max---that is important. They also suggest ordering includes alphabetically, which I've tried to follow, though that isn't as important.

Will do!