gostor / gotgt

Simple Golang iSCSI Target framework
Apache License 2.0
261 stars 49 forks source link

Some broken code snippet by go-vet tool #73

Closed cavanwang closed 6 years ago

cavanwang commented 6 years ago

I run "go vet ./..." for gotgt project, got some errors:

[cavan@n1 gotgt]$ go vet ./... 2>&1 | grep -v "composite literal uses unkeyed" | grep -v "vendor/" | grep -v "exit status 1" pkg/api/client/target_create.go:30: return copies lock value: github.com/gostor/gotgt/pkg/api.SCSITarget contains sync.Mutex pkg/api/client/target_create.go:34: return copies lock value: github.com/gostor/gotgt/pkg/api.SCSITarget contains sync.Mutex pkg/port/iscsit/iscsid.go:182: unreachable code pkg/port/iscsit/iscsid.go:252: unreachable code pkg/port/iscsit/iscsid.go:755: unreachable code pkg/port/iscsit/iscsit.go:126: literal copies lock value from *target: github.com/gostor/gotgt/pkg/api.SCSITarget contains sync.Mutex pkg/port/iscsit/login.go:151: wrong number of args for format in Errorf call: 2 needed but 3 args pkg/scsi/scsi.go:50: call of append copies lock value: github.com/gostor/gotgt/pkg/api.SCSITarget contains sync.Mutex pkg/scsi/spc.go:520: pg.Size too small for shift of 8 pkg/scsi/spc.go:552: pg.Size too small for shift of 8 pkg/scsi/spc.go:630: length too small for shift of 8 pkg/scsi/target.go:100: arg lun for printf verb %s of wrong type: uint64 pkg/util/util_linux.go:1: +build comment must appear before package clause and be followed by a blank line