gosu-lang / gradle-gosu-plugin

BSD 3-Clause "New" or "Revised" License
5 stars 7 forks source link

Clarify classpath vs. gosuClasspath in DefaultGosuCompileSpec and AntGosuCompile #10

Closed DPUkyle closed 8 years ago

DPUkyle commented 8 years ago

Other JVM language plugins keep a classpath argument, and a groovyClasspath/scalaClasspath too - both are FileCollections.

The Gosu plugin (as of 0.1.2-alpha) is confusing in its misuse of these parameters.

To clarify:

Finally, before creating a new ant process we will typically concatenate these two FileCollections. Ensure that gosuClasspath is added last, in case (for some reason) a different gosu-core jar is already added to classpath; first one wins with classpath resolution and appending gosuClasspath, rather than pre-pending, should preserve this behavior.

DPUkyle commented 8 years ago

This is fixed; before launching the AntBuilder we create a jointClasspath, which has some duplicated values. It might be worth de-duping this List at some point in the future, though there should be no functional change - it's purely cosmetic and would make debugging output easier to read.